RobustToolbox icon indicating copy to clipboard operation
RobustToolbox copied to clipboard

Don't overide the robust injectors and always use the build configuration

Open VasilisThePikachu opened this issue 1 year ago • 3 comments

Space station 14 has a "build client tools" batch file, as it turned out it error out instantly if you had never compiled release due to it overiding msbuild to forcibly use the release version. This pr removes that feature and just compiles it again for the target config.

VasilisThePikachu avatar Jul 06 '24 19:07 VasilisThePikachu

Ok wait I'm taking a look at this and the reason this is broken is different than I thought.

PJB3005 avatar Jul 06 '24 20:07 PJB3005

So this is fucking stupid. The solution is in fact configured to use the correct configuration when building for Tools: image

The problem is that compiling the project directly with dotnet run this gets completely ignored. For fuck's sake??? This makes absolutely no fucking sense what is the .NET SDK doing.

I don't know how we would go about fixing this short of adding a Tools build target to every project, which would be stupid as hell. Or figuring out the best spot to ask for support with MSBuild like this.

PJB3005 avatar Jul 06 '24 20:07 PJB3005

~~Wouldn't you ask the dotnet team? Don't they make msbuild?~~

You did

VasilisThePikachu avatar Jul 07 '24 00:07 VasilisThePikachu

Closing since we established this isn't the proper fix.

PJB3005 avatar Mar 24 '25 01:03 PJB3005