P33M

Please retest this on top of latest master - there have been changes which will impact this PR.

probe.c should include probe.h which already has the compile-time switches, and not the probe*pio.h file directly.

Can you update this PR on top of master and add UART_CTS as well?

The compile guard is wrong - it should be PROBE_IO_OEN. Please add another commit to this PR which fixes the typo.

Thanks, applied.

> @P33M Does the `picoprobe.uf2` at https://github.com/raspberrypi/picoprobe/releases/tag/picoprobe-cmsis-v1.0.3 work on the Pico W, or should there be a picow-specific UF2 file there too? No, flashing that will result in nonfunctional wireless....

Two things conspire to give reduced performance here - L1 entry/exit latencies get in the way of DMA, and a devicetree property that should optimise the USB3 controller transmit FIFO...

I've just hit this with rpi-update - compare pull/5882 with 6.1.74 -> bootloader probes NVMe, Linux fails to establish a link. On 6.1.74, Linux probes fine.

Reverting this hunk which changed between 6.1 and 6.6 fixes things for me. ``` @@ -393,42 +395,34 @@ static u32 brcm_pcie_mdio_form_pkt(int port, int regad, int cmd) /* negative return value...

I think the bug is doing readw into a u32 then testing the top bit for "done", and exiting if it's 0. This means writes done in rapid succession will...