Orvid King

Results 132 comments of Orvid King

Sorry for the delay on this. The current status is that enabling the json tests is fine, but for the benchmarks the default needs to have at least something checked...

Alright, so, as HHVM does require native functions to be properly declared, I have a version of the API that should be almost identical to the actual one, although documentation...

This is likely the result of a compiler bug, as the way it is currently written is intentional. Excluding this test for the versions of GCC where it fails to...

Which version of google-test are you compiling with? It sounds like this may just be us requiring a newer version than you're compiling against.

How was this tested? Would it be possible to add to the existing test suite?

I don't see a way to manually re-run it on the github side, but this built without errors on our internal Windows build, so should be good to go once...

Is this on a 32 or 64-bit platform? It's possible we've just failed to include ``.

Which versions of NVCC has this been tested with?

Generally speaking, folly only supports 64 bit architectures. There may be bits and pieces that work on 32-bit platforms, but overall Folly is entirely untested on them. If the fixes...