folly icon indicating copy to clipboard operation
folly copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Fix compilation with nvcc

Open luhenry opened this issue 1 year ago • 4 comments

These fixes are required to compile folly as part of velox with the NVIDIA toolchain. I expect these are mostly compiler-related bugs.

luhenry avatar Feb 21 '24 17:02 luhenry

@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Feb 21 '24 19:02 facebook-github-bot

Which versions of NVCC has this been tested with?

Orvid avatar Feb 21 '24 19:02 Orvid

@Orvid this has been tested with CUDA V12.2.140. This is the patchset that I've needed to be able to compile Velox on nvidia: https://github.com/rivosinc/velox/commit/05a892a21dbb3dd6335c9ab6b07626bac8e0eaca#diff-cd873badec87da0106ffc48d83c62dc7607bbd219ee8f31487a695aa304c6e46

cc @pedroerp

luhenry avatar Feb 22 '24 07:02 luhenry

@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Feb 26 '24 21:02 facebook-github-bot