Orvid King

Could you try again with https://github.com/facebook/folly/commit/437b29dd062a40c741b2147827025a2f413b76c7 ? I suspect it may still have issues building the test on some older versions of libstdc++ due to certain things in the standard...

FarmHash, and both spooky hash versions are used elsewhere outside of folly, so can't really be removed. I also suspect that this will be very hard to actually land due...

Incremental migration is likely the right way to go, but is not something that is viable to do from outside of FB unfortunately, as the scale is likely massive given...

I'll import this version to see how much breaks, but I am working on another version of this internally that should be much easier to actually roll out. We'll likely...

I failed to realize I hadn't updated our internal build system to account for the new source files from this PR, so the current results are that everything broke, but...

After the previous fixes there are still a couple of errors, but I suspect those are just flaky.

Enabling the json test for open source builds is good, but for the perf tests, we do have a benchmark framework (https://github.com/facebook/folly/blob/main/folly/Benchmark.h - With https://github.com/facebook/folly/blob/main/folly/test/AsciiCaseInsensitiveBenchmark.cpp as an example). The issue...

It's taken a bit for it land, but, as of https://github.com/facebook/folly/commit/c8a3dbc6a2ef0ac28fcf9b5552db6a6e82223044 benchmarks can now be built from CMake. It seems like we've broken trunk since then though. Could you adjust...

I suspect https://github.com/facebook/folly/commit/9d6acb35763d329d3fd6f4223ebf134f03e65d15 probably needed to be included for things to work. Could you try with that applied? If it works, I can release a patch version of folly and...

Sorry it's taken so long to actually get this fix landed, https://github.com/facebook/folly/commit/437b29dd062a40c741b2147827025a2f413b76c7 should fix this issue.