Oriol Abril-Pla
Oriol Abril-Pla
I left two still a bit conceptual comments in the discussion above, but it already looks good. I'll leave some more specific comments below to start getting the PR merge...
This `func` method for mcse should also replace [`mc_error`](https://github.com/arviz-devs/arviz/blob/9deaa5211cc4c18f1614b7c8dca7bef79ed73987/arviz/stats/diagnostics.py#L863)
Yes, that sound about right. How familiar are you with pytest? Have you checked some of the other test files? I was planning on adding the skeleton of the test...
test should be added on a new test file inside the `base_tests` folder, and I would recommend using a couple module level fixtures that can be used by test functions...
@madhucharan any news on this? Do you know roughly when will you have time to work on this? Right now it's not an immediate concern but this should be done...
Sounds good, let me know if you need any help
I haven't checked, but I'd guess it is related to https://github.com/pymc-devs/pymc-examples/issues/409. That is, the PR was opened before the error happened and needs a rebase to include the version pins,...
There is a typo caught by codespell check: https://github.com/pymc-devs/pymc-examples/runs/6758385057?check_suite_focus=true#step:5:84. "accomodate" only has one m and is being updated to "accommodate"
I volunteer to help with the PR. In fact this issue has given me the idea of extending plot pair using customizable functions. There would be 3 input functions, each...
About the arguments I would start with: ```python def plot_pair_extended( # arguments needed to mimic plot_pair data, var_names=None, coords=None, figsize=None, ax=None, # function arguments lower_fun=plot_kde, upper_fun=None, diag_fun=plot_posterior, # function kwargs,...