pymc-examples icon indicating copy to clipboard operation
pymc-examples copied to clipboard

Update LGCP notebook to v4

Open fonnesbeck opened this issue 2 years ago • 3 comments

In addition to updating to v4, I removed the second model from the notebook. The first model already takes upward of an hour to run on a reasonably fast PC; the second model takes almost a day.

The notebook has also been moved from the case studies folder to the gaussian processes folder.

fonnesbeck avatar Jun 01 '22 23:06 fonnesbeck

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

NB looks good, but pre-commit. Probably need to update myst file.

twiecki avatar Jun 06 '22 21:06 twiecki

There is a typo caught by codespell check: https://github.com/pymc-devs/pymc-examples/runs/6758385057?check_suite_focus=true#step:5:84. "accomodate" only has one m and is being updated to "accommodate"

OriolAbril avatar Jun 07 '22 14:06 OriolAbril