Robin
Robin
Hey @inside5545 thanks for your PR, In order to eventually merge this, we need to cover this with tests so that it is easier to maintain. Could you imagine writing...
this should also fix #3686
How can I help? What is still missing?
> @OrbisK I added tests today,but CI workflow seems to have a few problem,I haven't had a chance to check.The second thing is that #3686 you just mentioned,it still needs...
@43081j can you check the attw errors?
If we have browser-specific stuff here, we should cover that with browser tests.
> It's possible to [mock](https://github.com/microsoft/playwright/issues/2973#issuecomment-1747373220) the involved API's. However, this kind of circumvents the point of a test, since that test would just be testing our mocks. Agreed, let's test...
> > Sure, but by doing this we prevent `usePermission` and the subsequent `query` method from being called in Firefox. Just adding `alwaysRequireStreamToEnumerate` without refactor would still query the permissions...
I am not against relying on the useragent if it solves the problem. Is FF the only browser with this behaviour? And why? ------ A general thing with your PR...
I have found a discussion on w3c mediacapture https://github.com/w3c/mediacapture-main/issues/1019 ----- https://github.com/web-platform-tests/interop/issues/849#issuecomment-2489546740 > https://bugzilla.mozilla.org/show_bug.cgi?id=1928216