Robin

Results 220 comments of Robin

If we add this as `MaybeRef` we should also consider what we want to do it the ref updates

@hunterwilhelm this is true, but we are not reacting if the ref value changes

Perhaps we should give the user the option of whether or not to inject headers. We could add a `publicApplyHeader` function to apply headers via configuration.

Hey, Thank you for your PR Can you briefly explain the diff to https://vueuse.org/core/useMagicKeys/#usemagickeys? Thank you!

Thank you for the clarification. I think it should be possible to combine both composables into one. I would not have two composables that similar. Maybe we should update `useMagicKeys`...

> Instead of updating [their implementation](https://github.com/nuxt/ui/blob/d79da9d7b60c9972af64acd8e6eef4ae7d6bc3eb/src/runtime/composables/defineShortcuts.ts) I decided to make this function, so anybody can benefit, including Nuxt UI (if they want) since they use this lib already. If we...

I am not sure, if `import.meta.client` should be true here: https://github.com/nuxt/ui/blob/a813ea700e139e6b1de7a68da891b7d1ed079dc4/src/runtime/plugins/colors.ts#L52

not sure if we need: `if (import.meta.client && !import.meta.env.SSR && nuxtApp.isHydrating && !nuxtApp.payload.serverRendered) {` instead. Or: `if (import.meta.client && import.meta.env.VITE_SSG !== 'true' && nuxtApp.isHydrating && !nuxtApp.payload.serverRendered) {`. But I wonder...

related: https://github.com/antfu-collective/vite-ssg?tab=readme-ov-file#how-to-allow-rollup-tree-shake-your-client-code ?