Robin

Results 220 comments of Robin

> What I mean is to allow users to input multiple strings and implement random multiple-choice selection, rather than just returning numbers I think this should not be part of...

@john-li-creater If you agree, I will discuss this internally and, if necessary, make changes to your branch.

Can you share an up to date reproduction @mesqueeb?

as a workaround you can use ```ts onScopeDispose(() => { console.log('Unmounted about'); }); ```

Someday, we could follow up on this by merging the effects signal with its parent signals (`AbortSignal.any()`), which would remove the need for the cleanup array + loop. (Should be...

@9romise I think I have a proof of concept for replacing the cleanup array with the abort listener: https://github.com/OrbisK/vue-core/commit/a5a6a07b45fd269d13a3a938d9c323cfbed20f55. The benchmarks are mixed. Maybe you could take a look?

Go ahead if you have time. I am on holiday for two weeks. 😅

> What about browser compatibility? `AbortController` was definitely released after ES6 Correct me if I am wrong, but `AbortController` should not be related to es6? Or are you talking about...

Okay, got it. > In my opinion, not sure how worth all of this is though for the increased complexity. The question is how to detect if `addEventListener` supports `options.signal`...

> Relevant as well is the fact that `useFetch` first checks for support, so definitely something we want to do here. `useFetch` checks for AbortController (chrome>=66), but we need to...