OmriHab comments

Results 6 comments of


                                            OmriHab

Use a vector of integers instead of a string for faster computation

Could you let me know when you've added that branch? I would like to help contribute to the math functions using the new representation and anything else.

Use a vector of integers instead of a string for faster computation

Can i recommend using `uint64_t` from `cstdint`, instead of unsigned long long? unsigned long long is promised to be **at least** 64 bit but not certainly exactly 64. I assume...

Use a vector of integers instead of a string for faster computation

Alternatively unsigned long long can be used and just take into consideration that it isn't necessarily 64 bit. E.g the maximum would be `numeric_limits::max()` instead of `UINT_64_MAX`

Updated functions to vector format

I've updated the long long compare functions to be more efficient, that instead of building unnecessary `BigInt` objects and calling a lot of functions, get checked straight in the function....

Updated functions to vector format

Right, working on the fixes now, and thanks for the feedback! This is my first OS contribution so sorry if it's a bit rusty.

useSessionStorage is tied up to a component state and not to SS

The state is saved locally in the hook itself. On each state update the SS itself is updated, but the default value is read from the session storage once on...