BigInt icon indicating copy to clipboard operation
BigInt copied to clipboard
verified publisher icon faheel

Updated functions to vector format

Open OmriHab opened this issue 7 years ago • 3 comments

Tested partly locally, couldn't test with BigInt because I don't have all the functions needed to compile and test. Functions changed:

  • to_string
  • operator=
  • operator+/-
  • operator>>/<<
  • operator==
  • operator<

OmriHab avatar Apr 10 '18 19:04 OmriHab

I've updated the long long compare functions to be more efficient, that instead of building unnecessary BigInt objects and calling a lot of functions, get checked straight in the function. Also I added a conversion to 2 uint64_t's if long long is 128 bit, unlikely but adds reliability.

OmriHab avatar Apr 10 '18 21:04 OmriHab

Right, working on the fixes now, and thanks for the feedback! This is my first OS contribution so sorry if it's a bit rusty.

OmriHab avatar Apr 12 '18 11:04 OmriHab

@OmriHab Just wanted to let you know that I've been working on the conversion part (decimal string ↔ base 264 vector) and it's almost done. I'll push the changes in a while and you then update your PR with those. I'll also review the remaining changes in your PR once I push the changes.

faheel avatar Apr 20 '18 21:04 faheel