Olivier Cavadenti

Results 28 comments of Olivier Cavadenti

FYI Some JSON issues are released in Knex [2.5.0](https://github.com/knex/knex/releases/tag/2.5.0)

> I'm taking over this one @OlivierCavadenti as the fix is more complex than I thought, but you'll get credit 😉 . > > The fix should check if the...

This bug occurs at the time you read the lines from BufferedReader: ```js private List linesFromBufferedReader(BufferedReader reader) throws IOException { String line; List lines = new ArrayList(); while ((line =...

Thanks for you work @castarco I will review as soon as possible (it's seems CI fail because of Node12...xd)

Query is ok until positionBindings query: ![image](https://github.com/knex/knex/assets/10152806/bcb599e4-f619-4555-bc1f-9543d9f3c6db) As we can see "?" is replaced with "$1"

I think I find the fix for all ? escaping problems (also https://github.com/knex/knex/issues/5284, https://github.com/knex/knex/issues/5091, https://github.com/knex/knex/issues/5189). We have 3 differents implementations for search binding (Oracle, PG, MSSQL) with different regexes and...

In this case, the function want to replace, at the end before executing query, all bindings or all '\\?' with '?', but it fail. It seems at this time in...

I will take a look of this issue soon.