Olivier Cavadenti

> Fixed failing linting tests caused by this change. Sorry I should have run that before. > > When I run `npm run lint:everything` I see `The 'no-redundant-jsdoc' rule threw...

Also, I assume this will fix also https://github.com/knex/knex/issues/4688 ?

Ready for review ?

@LeopoldBriand as say in MySql documentation, user can define collation so `collate(collation : string);` can be enough and accept user defined collations.

hi, seems you still have one test fail on postgres.

still needed since we have prettier ? @Aschen

Cases are not tested here : https://github.com/kuzzleio/kuzzle/blob/fec478770d8ce0be0a46571888292d5421433b72/test/service/storage/queryTranslator.test.js Don't forget to add tests.

Hi, @kl0u did you find how to fix ? By the way I made some debugging and it's seems that when you add comment, the source code of CtFieldImpl object...

> > @Kytech : could you check on this again, please? > > Not really anything else I can do other than wait on that re-review. Knex maintainers seem to...

Hi, thanks for the contribution on https://github.com/knex/knex/pull/5478, I merge it just now.