Oliver King
Oliver King
That phasing plan makes sense to me. It's in-line with the [npm semantic versioning](https://docs.npmjs.com/about-semantic-versioning). It might make sense to [deprecate](https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions) the 0.x releases with a warning telling them that support...
I don't think putting both the new api and old api in the same package / directory makes sense to me. The fact that it's a breaking change between them...
Quick update: @davidgamero and I have been working on this for the last two weeks. We're having to make some changes to open-api generator to support the way we need...
> fetch > > * node >=17.5.0 has `--experimental-fetch`, which is using undici > * node >= 16, has undici support > * node < 16, maybe fallback to node-fetch...
I'm excited for this update but wanted to mention that I reproduced the steps and got an error on Stage 2. `Uncaught ReferenceError: module is not defined` is shown when...
Closed with #200 and action has been released. v4 (v4.1+) has this fix. Thanks!
I misunderstood what you were saying in #200. Will reopen.
My guess is that this is actually an error with the permissions you are giving the workflow. Did the permissions you are granting the workflow change? https://github.com/Azure/k8s-deploy/blob/531cfdcc3d41140ba29923fbcca51df1183e8610/src/strategyHelpers/deploymentHelper.ts#L143 https://github.com/Azure/k8s-deploy/blob/531cfdcc3d41140ba29923fbcca51df1183e8610/src/utilities/githubUtils.ts#L4
That looks right to me. It's not working with those permissions?
Some permission permission seems to just be missing from ```yaml permissions: id-token: write contents: read ``` I don't know what other one we'd need. There hasn't been any recent changes...