k8s-deploy icon indicating copy to clipboard operation
k8s-deploy copied to clipboard
verified publisher icon Azure

Fix annotations links using github.com even for GHES

Open nv35 opened this issue 3 years ago • 4 comments

There are few locations were github.com is hardcoded, making it incompatible with github enterprise servers that are hosted on other domains. From what I understood from these code lines, they are only cosmetic (sent as annotations in deployments).

https://github.com/Azure/k8s-deploy/blob/507f2d4fc713cdc92f96880e350464687ce2e960/src/utilities/workflowAnnotationUtils.ts#L24 https://github.com/Azure/k8s-deploy/blob/ca8d2604acf262265b6640fc4de4e060effbb555/src/utilities/githubUtils.ts#L47

There is GITHUB_SERVER_URL env var and some others to get the server domain.

nv35 avatar Jun 22 '22 11:06 nv35

Closed with #200 and action has been released. v4 (v4.1+) has this fix. Thanks!

OliverMKing avatar Jun 27 '22 18:06 OliverMKing

@OliverMKing the pull request #200 that i've opened is about api calls sent to github.com. This issue is about cosmetic links shown to the user. I don't see any correction yet in the repo.

nv35 avatar Jun 29 '22 10:06 nv35

I misunderstood what you were saying in #200. Will reopen.

OliverMKing avatar Jun 29 '22 14:06 OliverMKing

This issue is idle because it has been open for 14 days with no activity.

github-actions[bot] avatar Jul 13 '22 15:07 github-actions[bot]