Marco Pivetta

Results 1382 comments of Marco Pivetta

We may need https://www.php.net/manual/en/function.gc-status.php for this - it may give us information on anything not GC'd? I couldn't get a really useful example out of it, but only tried for...

Thinking out loud: ```php gc_collect_cycles(); $before = measure_allocated(gc_status()); run("first run", $test); gc_collect_cycles(); $run1 = measure_allocated(gc_status()); run("second run", $test); gc_collect_cycles(); $run2 = measure_allocated(gc_status()); assert(($run2 - $run1) === ($run1 - $before)); ```...

`SELECT COALESCE(yadda, yadda) AS HIDDEN thing FROM ... ORDER BY thing ASC`?

We don't support any kind of expression in the `ORDER BY` clause, as far as I can remember. I'm unsure what DB platform support looks like there...

Hmm... fairly sure that `ScalarExpression` won't work in `OrderByItem`... Do you know of any tests verifying it? I think the docs may be wrong here.

I would make a new interface, which is a mapper, rather than a hydrator. Hydration is indeed what this package does: the empty sponge is provided upfront, and it is...

As already asked in doctrine/DoctrineORMModule#446, please provide more detail about the expected results (compared to actual results)

@ibekiaris remove that `false` from the second constructor parameter of the `Paginator`

@ibekiaris can you check what SQL is being generated by the paginator, and how many results are found by it? Overall, this looks like a case where you have 3...