Marco Pivetta

Results 1382 comments of Marco Pivetta

@maglnet since I'm touching a lot of the project, you might want to take a glance here, especially to see how I'm ripping out pieces to use `azjezz/psl` instead, which...

The lexer only allows single quotes for now: https://github.com/doctrine/doctrine2/blob/a4d84e0cd8cc4ea1b99f4fd7d1d560f3fbe27c30/lib/Doctrine/ORM/Query/Lexer.php#L166-L169 Not aware of the implications of supporting also double quotes /cc @guilhermeblanco

Related to this, it would be good to have `write_only` also for the file contents, when uploading sensitive details, such as certificates that are generated/renewed in an ephemeral way.

I've seen this a number of times now: I think the action is not fetching all branches :thinking:

@manuelmrmorgado yep, had to downgrade to `2025.01.6` myself too: spikes are effectively the norm, right now, so something broke completely here. Looking at the diffs: https://github.com/wills106/homeassistant-solax-modbus/compare/2025.01.6...2025.01.8 I think the biggest...

Yeah, in cases where a `0` would be read, "unavailable" would be the correct metric. From what I can see, the entire logic is very much (correctly) abstracted away: https://github.com/wills106/homeassistant-solax-modbus/blob/84a6b1b6b3ba473e8d302166a5ea47fad4c24fa2/custom_components/solax_modbus/plugin_sofar.py#L2962-L2973...

> I switched to RS485 @cschlipf do you mean that you switched to a different hardware? If so, which?

@wills106 I can try jumping between `2025.1.6` (working -ish) and `2025.02.1` for some time, to observe the behaviour . I don't see any code (in the diff) that renders a...

Nope, we're back at having spikes: ![Image](https://github.com/user-attachments/assets/6e0edba5-71bc-4747-8e6b-8a26a6b546c3) ![Image](https://github.com/user-attachments/assets/5c121d9d-bcd6-4807-85e0-4a5b074ec759) ``` Logger: custom_components.solax_modbus Source: custom_components/solax_modbus/__init__.py:716 integration: SolaX Inverter Modbus (documentation, issues) First occurred: February 23, 2025 at 15:38:41 (1473 occurrences) Last logged:...

I found these relevant-ish logs from the 07:00~08:00 local time, where the readings where all broken ```log 2025-02-24 07:46:37.192 WARNING (MainThread) [custom_components.solax_modbus] zcs_inverter: read failed at 0x1023: feedin_limitation_mode  2025-02-24...