Marco Pivetta

Results 1382 comments of Marco Pivetta

@pdrosos can you PR the documentation directly? Editing from web also works :-) Consider checking #37 - this may be my mistake (merging that PR)

Misses tests...

What does "doesn't work" mean here? Are you getting an exception? What is the return value?

@elia-c I'd rather say that we should find out why the service is an empty array. It should rather be filled. We provided a dedicated service especially to prevent manual...

@polyfractal looking into PHPUnit is a good idea indeed. For now I simply renamed all my classes, so I wouldn't bother with this...

From the twitters, for whomever wants to pick up the task: https://github.com/symfony/symfony/blob/f0aa4e7df17d40eadf540c6c3d0f9e6feac67648/src/Symfony/Component/Console/CI/GithubActionReporter.php#L21

Cross-linking an implementation example: https://github.com/Roave/BackwardCompatibilityCheck/blob/54de7e8a200e458c3c449b0ff41d669a0eb1a88a/src/Formatter/GithubActionsFormatter.php Again, just for any takers :P

That timing seems extreme 😱 Could it be that coverage makes it so steep? What is the PHPUnit runtime, without mutations, but with coverage?

> So this patch slowes down the project ALOT. sweat_smile That's ~2 times the slowdown, which is much better than what I expected anyway :D