Christian Neumüller

Results 306 comments of Christian Neumüller

I think it's kind of a wash. All aws-API-specific attributes start with `aws.`, all db-related ones with `db.`. You can't have both. There are some remarks regarding use of `db.*`...

@joaopgrassi I think our on-paper contribution worklow was changed but the actual workflow never followed. https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#proposing-a-change > Follow the [issue workflow](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#issue-triaging) and make sure the issue is accepted with a...

@perseoGI This project is no longer maintained https://github.com/opentracing/specification/issues/163 @yurishkuro: The deprecation notice is quite well-hidden in the current GitHub UI, maybe add it to readme or set the repository to...

> The relevant SDK spec parts are already stable, but this could be introduced as an optional feature. I don't think that "stable" is that restrictive, but I think this...

Which information do you want to track about the datacenter? I feel like it would make sense to add it to the `host` semantic conventions at https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/semantic_conventions/host.md. If it's just...

> but then also would we want to have that true of the `cloud.md`? What do you mean? If the attribute should apply to things hosted in the cloud too?...

Personally I think that ~*only*~ mostly the exporter should be responsible for honoring timeouts. Aborting uncooperative threads has always been a bad idea. What we can do is add an...

> Firstly the module name message-handler doesn't seem appropriate as the code seems to deal only with aws messages. I think this is only sort of true. The code is...

In the docs for Dynatrace we recommend calling TraceAsync only with the actual event object, not the messages: https://docs.dynatrace.com/docs/shortlink/aws-lambda-otel-dotnet#sqs-sns-in After all, there is only one Lambda invocation, so calling TraceAsync...

I'm not 100% sure but won't it get the `faas.trigger`, etc. activity tags? That way, it would mean it was a separate Lambda invocation which it wasn't. So the faas...