Christian Neumüller

Results 306 comments of Christian Neumüller

Based on your hint, I now tried using `using var output = new StreamWriter("out.txt");` instead of `Console`, and indeed I see the finally line then. I will update the issue...

@jviau Hi, sorry for not replying, I missed this. Your question is answered by https://github.com/Azure/azure-functions-host/issues/9866: The stop callback is indeed called, but the console output is not visible.

I think if at least one set has more than one member, the current phrasing is clear and in these cases I would keep it as-is.

IMHO, attribute_group could (should?) be adapted to fulfill these instead of adding another type

This is a mixed repository which also contains other tooling (proto build).

This seems like a bit of a hack to me and maybe a mis-use of "ref" to compensate for a lacking feature. Would it be better to first decouple the...

Both, I think 😃 (It's the same with the `ref:` suggestion though, at least I would say that the type becomes a different one if you add values, and that...

> when value is removed it breaks every lib that used it That will be the case no matter how you implement code generation. You can at most make it...

> should this also be for traces I don't think this applies to traces. For traces, we have required attributes, but either you track a certain operation or not. We...

@jkwatson I did not know myself, but we already merged support for that: https://github.com/open-telemetry/build-tools/blob/main/semantic-conventions/src/opentelemetry/semconv/templating/code.py#L28