Christian Neumüller

Results 306 comments of Christian Neumüller

What do we do with the flags we added on the link then? It would be inconsistent to store the unmodified incoming flags on the link message but the "span's...

Why the xor? To save a few bits on the wire when they are mostly zero?

Can we assign a milestone for this issue? Any release that wants to offer a full OpenTracing or OpenCensus compatibility layer will need this feature.

Also, we need that feature at Dynatrace and will have to stay on an older version of the Java API until this is fixed.

The link would not be dangling (pointing to a non-existent span) but a null-link (pointing to the all-zero trace+span ID).

I did not see that null-links were already mentioned, but I think this is a case where leaving it undefined is harmful.

Ping @lmolkova, just stumbled upon this, maybe the messaging SIG is interested in reviving this issue (sorry if it's already on your radar anyways -- nothing urgent for me)

Since I just found that one again: A bit related is the general definition of an "invalid" SpanContext which is rather broad and can lead to information loss: https://github.com/open-telemetry/opentelemetry-specification/issues/753

This requires #437 "Update Binary format in the Specification" (since #426 removed it; it was there before but was "temporarily" removed due to a larger refactoring of both in-process and...

> With that said - what work are you exactly wanting to do on shutdown? In the real use case, we want to shut down OpenTelemetry (not actually via code...