OBarronCS
OBarronCS
Yes - I made the last changes for correctness and did more testing locally on x86. It's ready to go! It will currently be enabled for x86.
> `set highlight-color` can implement `@trigger` and override global `highlight_func` variable? Nice! This works locally: ```python highlight = generateColorFunction(config.highlight_color) @config.trigger(config_highlight_color) def test(): global highlight highlight = generateColorFunction(config.highlight_color) ``` There are,...
Awesome - I dynamically add a trigger to update the functions in #2977
One round of optimizations applied in #2977. See https://github.com/pwndbg/pwndbg/pull/2977#discussion_r2091978493 for further optimization ideas.
> Does it makes sense? What if someone is in a loop and puts a conditional breakpoint a few instructions forward to let the loop iterate a few times wouldn't...
One part of this looks like a Capstone bug - Based on this test-suite on 32-mips, they are converting the r30 (0x1e) register to $fp, and "$s8" is not involved....
I think the linked PR would fix this bug - thumb mode would always be true (although I'm not entirely sure how changing the frame messes with the thumb bit...
Making an attempt to upgrade WebAssembly to auto-sync with https://github.com/capstone-engine/llvm-capstone/pull/87 and https://github.com/capstone-engine/capstone/pull/2816
I follow that interpretation of the instruction as well as the desire to keep this aligned with LLVM. I want to note that for aarch64, which has the same instruction...
For memory loads/stores, like `mov rax, qword ptr [rip + 0x2edc]`, I find it important for the annotation to express both the memory address being loaded (for example, seeing the...