Andrew comments

Results 205 comments of


                                            Andrew

fix(core/quest): improved flight of the wintergarde defender

Thanks for the PR 👍

fix(core/quest): improved egg collection

Please use the spellcorrections cpp file to make dbc changes

fix(core/quest): improved egg collection

> > Please use the spellcorrections cpp file to make dbc changes > > why this change? The spell_dbc database table is designed for: 1) server side spells (changing those...

[WIP] Fix (Core/SmartScript.cpp) Control the change of faction

I believe the merge conflict resolution went wrong. This is removing SMART_ACTION_SET_INST_DATA64 completely. Also, the bottom change doesn't make sense. Creature level update doesn't have anything to do with faction......

feat(Core): Implement SP Bonus Coefficients from DBC

> > 認為其他人會使用谷歌翻譯或不同的網站來關注這個對話？ 😂 > > Nah, people wouldn't do that. 😛 Yep. Np. ![image](https://user-images.githubusercontent.com/47818697/182008679-4838b003-9ab6-4854-8510-7acd217c5f48.png)

fix(Core/Items): BoP stackable items can be traded among raid members.

When an item is added to an existing stack, which rule prevails? Will the old stack be tradeable or will the new itens be impossible to trade?

fix(Core/Items): BoP stackable items can be traded among raid members.

Wrong, they shouldn`t be tradeable, the stack removal thing was... wow classic?

fix(Core/Items): BoP stackable items can be traded among raid members.

Sorry, I got lost after the last researches. I'm not sure how it should work, but it seems to me stackable items shouldnt be tradeable because of the overlaping rules...

[AQ Quest] The Path of the Righteous

Usually the event is prevented from starting again until it finishes running. Phased events were not a thing until Cata at least, I believe.

fix (Quest 9740): The Sun Gate

Question: can you click the portal straight away without destroying the crystals?