Andrew comments

Results 205 comments of


                                            Andrew

fix (Quest 9740): The Sun Gate

@xadowtek thanks for the PR 👍

chore(scripts/RuinsOfAhnQiraj): cleanup ruins_of_ahnqiraj.h

I posted images of what I saw, and the merge had issues I see that those issues were either corrected already or GitHub had issues displaying the merge PR I...

fix(Scripts/AhnQiraj): Implemented General Andorov event.

I already implemented the waves... We just need to spawn andorov

fix(Scripts/AhnQiraj): Implemented General Andorov event.

Because Andorov isn't related to Rajaxx waves (it is just an alternate start) and I didnt do anything with Andorov. You can pull Rajaxx by talking to Andorov but they...

Majordomo Executus Broken RP

He shouldn’t have the gossip flag until he teleports. Maybe a regression from the gossip flag check PR

fix(DB/gossip_menu_option_locale): Populate missing locale entries from broadcast_text (zhCN)

Hmm SQL import is erroring

Feature: automatic DB export to DBC on server startup

There’s something I don’t understand here: The server uses DBC files (exported from MPQ) The client uses MPQ files. The server already has database tables that read from DBC files...

Basic Campfire could be stacked on top of each other

The spells that spawn gameobjects like campfire and fish feast should check absolute Z position and not relative, so they always spawn on ground and not on top of other...

Feature: Elemental weapon damage

Frost damage wands deal frost damage correctly

fix(Core/Spells): Area or assembly zone restriction

Thanks for the PR, but same issue as the other one: spelldbc corrections need to go to the CPP file, we don't override clientside spells by adding into that table