Release planning

[gilest]

V5

• [x] V2 conversion #391
  • Consuming apps now require ember-auto-import v2
  • Dropped Ember "Classic" support
  • Dropped Ember 3.24 support. Minimum supported version is now 3.28
• [x] Replace blueprint with explicit test helpers #392
• [x] #396
• [x] https://github.com/adopted-ember-addons/ember-cli-flash/pull/398

V6

• [x] Convert FlashObject to native class #394
• [x] Convert FlashMessagesService to native class #409
• [x] Remove computeds from FlashMessagesComponent #410
• [ ] Migrate files to typescript and publish proper declarations

[NullVoxPopuli]

https://github.com/adopted-ember-addons/ember-cli-flash/blob/master/ember-cli-flash/src/test-support.js

does it make sense to make this automatic at all? rather than manually invoked?

[gilest]

does it make sense to make this automatic at all? rather than manually invoked?

I'm not sure I understand what you mean 🤨

There is an "automatic" default – the timeout behaviour is disabled during test runs.

The helper sets an option which overrides this default. Most users will never need to use the helper. It's a compatibility patch which allows for fine-grained control of test behaviour.

Implementation in FlashObject Upgrade guide

[NullVoxPopuli]

Oh ok, thanks for the link!

[gilest]

Today I have tested the dist build in two apps:

• relatively modern ember app with classic build
• modern, fastbooted ember app with fully static embroider

In both apps the test suite passes and I have manually verified that flash messages show as expected.

I think we're ready to cut a 5.0 major @NullVoxPopuli . Happy to help with this

[vlascik]

I also already converted this addon to native classes (typescript, really) in https://github.com/adopted-ember-addons/ember-cli-flash/pull/390. There's a problem there, with either lint or tests failing, but maybe someone could take a look at it for an hour or two and get it through the finish line.