Artyom Abakumov comments

Results 9 comments of


                                            Artyom Abakumov

Add json-related blr, constants, messages and DSC changes

> I don't think partial changes should be integrated. This PR was created because of blr. Reserved blr_josn will help avoid unnecessary conflicts in the future. > It would also...

Add json-related blr, constants, messages and DSC changes

> I see no problems reserving `blr_json` (or maybe it should better be named `blr_json_func`?), either explicitly or in the commented form. However, the rest of the changes should better...

Trace failed attaches #7580

> To be precise - TraceManager is not utility. Placing it into utilities folder is rather confusing. BTW, keeping in jrd is also bad idea - that's not part of...

ambiguous overload for 'operator[]' of Json::Value' when compiled for x64

I have the same issue with Visual Studio 2022.

Copy-pasted code in engine

> Why this issue for feature/bug if there are the pull requests (that is same thing as an issue) that already tracks the change? I wanted to address the issue...

Merge putDtype and putType; remove duplicated code

> If you not choose better names for methods you created to not duplicate code, I prefer to have the code duplicated. I understand nothing what the refactored methods do...

Internal consistency check (page in use during flush) with small number of DefaultDbCachePages

Here is a dump form the Debug virsion with consistency check: https://drive.google.com/file/d/1Gv9KYzSeVBNlkixLcWuL_aqi3zWKuJyI/view?usp=sharing

Internal consistency check (page in use during flush) with small number of DefaultDbCachePages

> Could you try with `FLUSH_ALL` ? It seems to have helped. The bugcheck no longer occurs

Move blob search logic in Replicator into a new method to prevent code duplication

> Note, `updateRecord()` should not put blob into log if it was not changed. Thus it should have a bit different code. I can prepare a patch with such improvement...