firebird icon indicating copy to clipboard operation
firebird copied to clipboard
verified publisher icon FirebirdSQL

Copy-pasted code in engine

Open Noremos opened this issue 6 months ago • 2 comments

Hello. During JSON type implementation, I encountered multiple code duplications in the engine. To simplify future work, I decided to create several PRs with proposed improvements. There are 3 of them:

  1. putType and putDType merge https://github.com/FirebirdSQL/firebird/pull/8610
  2. Use a method for impure string allocation https://github.com/FirebirdSQL/firebird/pull/8609
  3. More csb_repeat::getName usage https://github.com/FirebirdSQL/firebird/pull/8611

Noremos avatar Jun 18 '25 14:06 Noremos

Why this issue for feature/bug if there are the pull requests (that is same thing as an issue) that already tracks the change?

asfernandes avatar Jun 19 '25 00:06 asfernandes

Why this issue for feature/bug if there are the pull requests (that is same thing as an issue) that already tracks the change?

I wanted to address the issue of copypasta code in general and track related PRs. If you think it's a bad idea, I'll close this issue.

Noremos avatar Jun 19 '25 06:06 Noremos