cc-rs icon indicating copy to clipboard operation
cc-rs copied to clipboard

Bump msrv to 1.85

Open NobodyXu opened this issue 5 months ago • 11 comments

Debian 13 has released with rustc 1.85

NobodyXu avatar Aug 10 '25 08:08 NobodyXu

I hope this won't be merged/released for a few more months.

djc avatar Aug 10 '25 08:08 djc

I agree that we should at least wait for weeks, at least until many has migrated to debian 13

NobodyXu avatar Aug 10 '25 09:08 NobodyXu

Is Debian the only consideration?

RHEL 8/9/10 only have 1.84 right now, but they'll be upgraded in the next minor release, around November.

cuviper avatar Aug 10 '25 15:08 cuviper

RHEL 8/9/10 only have 1.84 right now, but they'll be upgraded in the next minor release, around November.

Thanks, it sounds good to wait until then

NobodyXu avatar Aug 11 '25 08:08 NobodyXu

Todo

  • [ ] change max_by to max_by_key
  • [ ] use std::sync::OnceLock

NobodyXu avatar Aug 21 '25 09:08 NobodyXu

looks like msrv 1.70 is more reasonable, it contains many stdlib API we want

NobodyXu avatar Aug 30 '25 03:08 NobodyXu

Debian 13 has released with rustc 1.85

The logic is flawed. The fact that a specific vendor released a thing doesn't mean that a) everybody is running the same distro, b) everybody immediately upgrades. If anything, the community is better served if the decision is governed by when releases go out of support, not by when they are released.

dot-asm avatar Sep 21 '25 17:09 dot-asm

I'm not planning to merge this PR right now, it's going to be months before it's merged

NobodyXu avatar Sep 22 '25 00:09 NobodyXu

The relevant zulip discussion.

ChrisDenton avatar Sep 22 '25 00:09 ChrisDenton

The relevant zulip discussion.

Relevant question is if those minority users are simply being obtuse or have no choice. I for one have no choice when I target ARM Morello. They have updated to 1.72 in September. From 1.56. But of course you don't have to care :-) But I do ~pledge~ implore you to not assume that everybody runs Debian and is about to upgrade.

dot-asm avatar Sep 22 '25 10:09 dot-asm

Yes we would probably bump msrv to 1.70 instead, in 6-12 months or even longer

NobodyXu avatar Sep 22 '25 11:09 NobodyXu