Nimish Purohit

Results 28 comments of Nimish Purohit

Feature/predict

@ankurankan Sure, I was confused about that.

Fixes GES implementation

@ankurankan Waiting for your review when you get time. I think the changes should be split into two PRs - one for the PDAG class (which had plenty of issues),...

Modified .predict() method for more inference methods.

On it.

Modified .predict() method for more inference methods.

@ankurankan I think it is ready for a review. Inform me in case more changes need to be accommodated in the docstring or code!

Modified .predict() method for more inference methods.

My bad for missing it!

Replace our `Tri` op with an `OpFromGraph`

@jessegrabowski New contributor here. I created a PR based on my understanding of the issue. It probably has a few errors. I was unable to run pytest locally due to...

Add functions to compute Structural Hamming Distance and Structural Intervention Distance

@jihyeseo In case you were asking me, I am not working on SID. @ankurankan may clarify if someone else is working on it.

Key Error when log_likelihood_score is called when using "torch" backend

Thanks @HarshSaini10 , you can create a PR for the fix. You could simply search the codebase for keywords where a similar computation may be happening, to find if this...

Addition of PCMCI estimator and TimeSeriesDAG, a new Base class

> @Spinachboul > > > I still need to add the references here in the PCMCI docstrings, and I am not sure which one would be suitable for it. >...

Addition of PCMCI estimator and TimeSeriesDAG, a new Base class

Do you mean the CI tests? I think it is controlled by @ankurankan, he can probably enable it from his side. Of course, you can test it locally using pytest.