Nimish Purohit

@ankurankan Yep definition wise it would be better to handle that in the expert knowledge class itself, would look cleaner.

Yep, that seems to be the issue. Will take it up after my current PRs are resolved, if it is not fixed by then.

@jessegrabowski My bad for missing it, I'll make the change. @ricardoV94 If that is appropriate in scope for me, I'll be okay with working on it.

@jessegrabowski Made the change. I have left the docstring of `iota` mostly the same, but I guess the example section may need to be removed now? Tests are pending, I'll...

@jessegrabowski The tests were passing for `tri` but now the tests for `tril` and `triu` are failing. The issue seems, in [the test](https://github.com/pymc-devs/pytensor/pull/1276/commits/5172a520347200b6d452e82507e3ffc29e80eb90#diff-6e979bcb6a1b725f884a9932077a3bed3ced47d8ef2777796c1dd42a6738b099R1029) we are passing the matrix as a...

@jessegrabowski I made the change, the tests are passing now. I have removed 'complex64' `dtype` from the tests for now, because there seemed to be some compilation error which I...

@jessegrabowski ~~The stack trace looks like (removed some parts)~~

@jessegrabowski Also stuck at this [test case](https://github.com/pymc-devs/pytensor/blob/f10a6036ab0c24149565f469946d46f4d4922672/tests/link/jax/test_tensor_basic.py#L204); seems to be failing because we are passing concrete values instead of symbolic ones (I think). The same is tested in the test...