rust
rust copied to clipboard
Mention Register Size in `#[warn(asm_sub_register)]`
Fixes #121593
Displays the register size information obtained from suggest_modifier()
and default_modifier()
.
r? @lcnr
rustbot has assigned @lcnr. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
r? compiler
That looks very reasonable but I don't know this area
r? compiler
@bors r+ rollup
:pushpin: Commit 1bde8281415034fd76a031c5e939251ff12ea60f has been approved by fmease
It is now in the queue for this repository.
@bors r- https://github.com/rust-lang/rust/pull/122466#issuecomment-1996731201
@bors rollup=iffy
@rustbot ready
@bors r+
:pushpin: Commit afc99cc976268885da8aa0457a707306c780c6c6 has been approved by fmease
It is now in the queue for this repository.
:hourglass: Testing commit afc99cc976268885da8aa0457a707306c780c6c6 with merge 8f57c96b7c9f351eb1f205d7d9ba7bff47219b00...
Ah, since we have so many rollup=never PRs in the queue, let's prioritize them. Didn't know rollup=iffy + great age would sort a PR above rollup=never PRs.
@bors rollup-
@bors retry (giving way)
A job failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
That is better done by giving them prio, imo. doing so. @bors rollup=iffy
though i dont think it really matters, in the end all PRs will be tested, no matter whether this one or a different one is first. if a PR wants to be tested before others because of potential conflicts, it should p=1, but usually it doesn't really matter
:hourglass: Testing commit afc99cc976268885da8aa0457a707306c780c6c6 with merge 8fee3f655025b75221d71e96f1033f5990ef773f...
:broken_heart: Test failed - checks-actions
A job failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
Looks like a network issue.
@bors retry
:hourglass: Testing commit afc99cc976268885da8aa0457a707306c780c6c6 with merge 4a52e9cc2acf102da113d1b6c712afc5fcf4db13...
Thanks, this is great. :)
Would probably be good to have tests for these warnings as well.
ones aside from the tests for the warnings that already exist? :thinking:
Uh... I must have been blind when I looked at the PR diff as I saw no test changes. Please ignore me...