rust icon indicating copy to clipboard operation
rust copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

Mention Register Size in `#[warn(asm_sub_register)]`

Open veera-sivarajan opened this issue 5 months ago • 3 comments

Fixes #121593

Displays the register size information obtained from suggest_modifier() and default_modifier().

veera-sivarajan avatar Mar 03 '24 14:03 veera-sivarajan

r? @lcnr

rustbot has assigned @lcnr. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Mar 03 '24 14:03 rustbot

r? compiler

lcnr avatar Mar 04 '24 14:03 lcnr

That looks very reasonable but I don't know this area

r? compiler

Nadrieril avatar Mar 04 '24 15:03 Nadrieril

@bors r+ rollup

fmease avatar Mar 14 '24 02:03 fmease

:pushpin: Commit 1bde8281415034fd76a031c5e939251ff12ea60f has been approved by fmease

It is now in the queue for this repository.

bors avatar Mar 14 '24 02:03 bors

@bors r- https://github.com/rust-lang/rust/pull/122466#issuecomment-1996731201

matthiaskrgr avatar Mar 14 '24 07:03 matthiaskrgr

@bors rollup=iffy

fmease avatar Mar 15 '24 01:03 fmease

@rustbot ready

veera-sivarajan avatar Mar 20 '24 23:03 veera-sivarajan

@bors r+

fmease avatar Mar 22 '24 16:03 fmease

:pushpin: Commit afc99cc976268885da8aa0457a707306c780c6c6 has been approved by fmease

It is now in the queue for this repository.

bors avatar Mar 22 '24 16:03 bors

:hourglass: Testing commit afc99cc976268885da8aa0457a707306c780c6c6 with merge 8f57c96b7c9f351eb1f205d7d9ba7bff47219b00...

bors avatar Mar 22 '24 16:03 bors

Ah, since we have so many rollup=never PRs in the queue, let's prioritize them. Didn't know rollup=iffy + great age would sort a PR above rollup=never PRs.

@bors rollup-

fmease avatar Mar 22 '24 16:03 fmease

@bors retry (giving way)

fmease avatar Mar 22 '24 16:03 fmease

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-log-analyzer avatar Mar 22 '24 16:03 rust-log-analyzer

That is better done by giving them prio, imo. doing so. @bors rollup=iffy

workingjubilee avatar Mar 23 '24 00:03 workingjubilee

though i dont think it really matters, in the end all PRs will be tested, no matter whether this one or a different one is first. if a PR wants to be tested before others because of potential conflicts, it should p=1, but usually it doesn't really matter

Noratrieb avatar Mar 23 '24 15:03 Noratrieb

:hourglass: Testing commit afc99cc976268885da8aa0457a707306c780c6c6 with merge 8fee3f655025b75221d71e96f1033f5990ef773f...

bors avatar Mar 24 '24 04:03 bors

:broken_heart: Test failed - checks-actions

bors avatar Mar 24 '24 04:03 bors

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-log-analyzer avatar Mar 24 '24 04:03 rust-log-analyzer

Looks like a network issue.

@bors retry

workingjubilee avatar Mar 24 '24 04:03 workingjubilee

:hourglass: Testing commit afc99cc976268885da8aa0457a707306c780c6c6 with merge 4a52e9cc2acf102da113d1b6c712afc5fcf4db13...

bors avatar Mar 24 '24 11:03 bors

Thanks, this is great. :)

Would probably be good to have tests for these warnings as well.

RalfJung avatar Mar 24 '24 11:03 RalfJung

ones aside from the tests for the warnings that already exist? :thinking:

workingjubilee avatar Mar 25 '24 00:03 workingjubilee

Uh... I must have been blind when I looked at the PR diff as I saw no test changes. Please ignore me...

RalfJung avatar Mar 25 '24 07:03 RalfJung