NikLeberg
NikLeberg
> What is missing while CI? Oh, I haven't noticed that the action for pr https://github.com/SpinalHDL/docker/pull/11 did fail and you had to revert. I'll loot into it. > Does it...
Why is `pastValid()` implemented with `initial()` instead of `init()` ? See [`formal/package.scala#L20`](https://github.com/SpinalHDL/SpinalHDL/blob/42b22b3eea7db0d9570ba3d17c2828673c47dd3a/core/src/main/scala/spinal/core/formal/package.scala#L20) ```scala def pastValid() : Bool = signalCache(ClockDomain.current -> "formal.pastValid")(RegNext(True) initial(False) setWeakName("formal_with_past")) ``` This fails in VHDL, where the...
In both cases (using `init` or `initial`), the following verilog is emitted: ```verilog initial begin formal_with_past = 1'b0; end always @(posedge clk) begin formal_with_past
I added commit #[94f07b1](https://github.com/SpinalHDL/SpinalHDL/pull/1429/commits/94f07b166a76ad7d0ddcea888449ac5de40b7f31) that implements the discussed change from `initial` to `init` for the formal `pastValid`. Maybe @Dolu1990 can help us out and explain if we would break something...
About CI.. I don't think your pr #1455 did what you think it did? It is now using the `latest` tag that was last pushed/released to one year ago.
Ah, so I have to change the image tag that is used in the action yaml? Can do... that commit shall never enter dev though. I can also test under...
Hi @Readon I think implementation wise this is done. I'm passing all tests locally with latest upstream GHDL version #[3b05281](https://github.com/ghdl/ghdl/commit/3b05281987f194478fea538a843411c775931a09). This latest GHDL version is required as there was a...
The failures in `tester-formal` were because: - I forgot to change an assert in `FormalApiTest` -> fixed - CI did not yet use the updated (https://github.com/SpinalHDL/docker/pull/15) docker image -> a...
> Is it possible to split the ghdl related test case into standalone CI jobs? Currently there is no difference made between default symbiyosys or ghdl formal tests. They just...
Some tracking information to have an overview of crashes and fixes: | Crash File Hash | State | PR | | --- | --- | --- | | `0c1d01dd6f3aea51f8b086c4c788132486f2bfe6079eb33e89f4e69d39945bc7` |...