Nihal Jain
Nihal Jain
Hi @eubnara Welcome and thank you for your first PR in Apache HBase.Please have a look at the review comments and please let me know if you need any support.
Hello guys, I do not see any movement here. Now, do we want to replace log4j with log4j2 here? I could take that task up if others are interested.
This is a backport of https://github.com/apache/phoenix/pull/1745
Rebased code and verified no new instances of createSourcesJar in code. Could you please merge this.? CC: @gjacoby126 @stoty
Hi @stoty are we good here? Also please let me know if should take this to 5.1. Will need to raise another PR as seems an additional file change is...
Please donot push this to 5.1, have raised another PR for 5.1 as code is a bit different.
> I have tested this now, but the shading time difference is seems to be minimal. On my machine it takes ~3:20 with the shaded sources, and ~3:05 without them....
Rebased code and updated all new instances of createSourcesJar in code. Could you please review and merge this.? CC: @gjacoby126 @stoty @virajjasani
We should also remove the include statement at https://github.com/apache/hbase/blob/master/hbase-assembly/src/main/assembly/hadoop-three-compat.xml#L43, right?
Draft PR with changes from the last submitted patch in HBASE-18999. I have run hbase build with this change along with the shell test cases. Pending: * Will do a...