hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-18999 Shell support for multiple columns for DML commands

Open NihalJain opened this issue 2 years ago • 12 comments

NihalJain avatar Dec 16 '23 15:12 NihalJain

Draft PR with changes from the last submitted patch in HBASE-18999. I have run hbase build with this change along with the shell test cases.

Pending:

  • Will do a self review and see if code/docs can be improved. For example I see some cryptic code in put.rb /append.rb
  • And also test out using a shell instance.

CC: @Apache9

NihalJain avatar Dec 16 '23 15:12 NihalJain

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 2m 15s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 5s master passed
+1 :green_heart: spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 52s the patch passed
-0 :warning: rubocop 0m 19s The patch generated 200 new + 395 unchanged - 12 fixed = 595 total (was 407)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: spotless 0m 41s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
11m 15s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5585
Optional Tests dupname asflicense javac spotless rubocop
uname Linux 0cb042f9f2ce 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b7c3f8c6e3
Default Java Eclipse Adoptium-11.0.17+8
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/console
versions git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 16 '23 15:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 2m 10s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 59s master passed
+1 :green_heart: javadoc 0m 10s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 41s the patch passed
+1 :green_heart: javadoc 0m 9s the patch passed
_ Other Tests _
+1 :green_heart: unit 6m 44s hbase-shell in the patch passed.
15m 42s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5585
Optional Tests javac javadoc unit
uname Linux 1a1668a49eb5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b7c3f8c6e3
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/testReport/
Max. process+thread count 1585 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 16 '23 15:12 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 3m 26s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 36s master passed
+1 :green_heart: javadoc 0m 12s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 20s the patch passed
+1 :green_heart: javadoc 0m 8s the patch passed
_ Other Tests _
+1 :green_heart: unit 6m 53s hbase-shell in the patch passed.
16m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5585
Optional Tests javac javadoc unit
uname Linux cc1bc9bd7a55 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b7c3f8c6e3
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/testReport/
Max. process+thread count 1525 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Dec 16 '23 15:12 Apache-HBase

Pushed local changes, still not ready, will do a little more self review and testing. Will take up later.

NihalJain avatar Jan 06 '24 17:01 NihalJain

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 24s master passed
+1 :green_heart: spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 53s the patch passed
-0 :warning: rubocop 0m 20s The patch generated 201 new + 396 unchanged - 15 fixed = 597 total (was 411)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: spotless 0m 41s patch has no errors when running spotless:check.
_ Other Tests _
+1 :green_heart: asflicense 0m 8s The patch does not generate ASF License warnings.
9m 46s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5585
Optional Tests dupname asflicense javac spotless rubocop
uname Linux 95c7088b2ea7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4aeabdcc71
Default Java Eclipse Adoptium-11.0.17+8
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/console
versions git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 06 '24 18:01 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 37s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 58s master passed
+1 :green_heart: javadoc 0m 12s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 48s the patch passed
+1 :green_heart: javadoc 0m 11s the patch passed
_ Other Tests _
-1 :x: unit 6m 59s hbase-shell in the patch failed.
14m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5585
Optional Tests javac javadoc unit
uname Linux 1c62e1db533a 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4aeabdcc71
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/testReport/
Max. process+thread count 2029 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 06 '24 18:01 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 26s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 37s master passed
+1 :green_heart: javadoc 0m 14s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 24s the patch passed
+1 :green_heart: javadoc 0m 8s the patch passed
_ Other Tests _
-1 :x: unit 7m 45s hbase-shell in the patch failed.
15m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5585
Optional Tests javac javadoc unit
uname Linux b2ef01abe68e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4aeabdcc71
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/testReport/
Max. process+thread count 1987 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 06 '24 18:01 Apache-HBase