Jordan Atwood

Results 370 comments of Jordan Atwood

Our general philosophy is that the calculator should be used for calculating actions needed, not necessarily showing unlockable/available skill actions. You're correct that some not-often-repeated actions are there, however we...

This needs rebase since gameval definitions exist now, though it looks good at a glance.

So you're requesting the same feature that's already offered in the attack styles plugin, but without removing the buttons from the interface? (so clicking them would have no effect) That...

Fixed in 174e5c86dd2fe9f57104c0d36b76c42af39d790d

I've not reviewed the code whatsoever, but do you have permission from limpwurt to use his voice clip in this way?

You should not [use the C Engineer plugin's icon](https://github.com/Gavin-TC/limpwurt-login/blob/3906a2c888e94479c359bf8b41f5623c46be1b54/icon.png) for this plugin. Code LGTM otherwise

The bank equipment inventory is fixed in 13073fd235b386f17640bdef53468d23194446c8. https://github.com/runelite/runelite/commit/8e730934d1c50ccf20eb4868a2860712c506e725 would also fix the standard equipment inventory. (related: #12129) I have not run ToA in some time, but I will try...

Equipment inventory is fixed in 92a3ded096957e39d21700f86e3af4b049966ee1; I still need to test and fix ToA resupply inventory.

Do you have any thoughts on prodigy's comment above? I'm happy to review this if it's still wanted, but if dink covers this use case sufficiently, I'm happy also for...

This LGTM. Do you want to rename your repository to match the new (that is, no-longer exclusive to Sol Heredit) behavior before it's added?