Jordan Atwood
Jordan Atwood
No, we would close the PR if we came to that decision. I expect your changes are probably sufficient, but I haven't reviewed this plugin and ron probably has not...
You must ensure the added infobox is removed when your plugin is turned off; currently no `shutDown()` method exists, so this is not happening.
Closing due to inactivity.
This has been failing to build for nearly 2 months with no follow-up.
Apologies, I missed that context from #3350. [Per Adam's comment](https://github.com/runelite/plugin-hub/pull/3350#issuecomment-1312858429), you still need to update plugin-hub's `verification-metadata.xml` in this PR, similar to how this is done in #2795, rather than...
Hi, sorry for the exceptionally long delay in response on this PR. Unfortunately we're not going to accept it to the plugin hub at this time because we would need...
[Based on this commit](https://github.com/Felanbird/runelite-plugin-hub/commit/bd0b598987b6c086a23388842a0287863ba5131b), use `CACHE_VERSION=2.4.0`.
Most of these action updates seem fairly innocent. The only ones I see being potentially problematic are upload-artifact and download-artifact because artifacts created on v3 are not necessarily compatible with...
I think adding audio cues to this mechanic, where none exist by default, is an overreach and not something we're interested in adding.
Closing due to the abovementioned concerns and inactivity.