plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

Create No Steven plugin

Open two-zee opened this issue 1 year ago • 7 comments

A RuneLite plugin that hides everything related to the "SteVen" bots that plague F2P.

It can hide their:

  • Entities (e.g. models)
  • 2D entities (e.g. hitsplats)
  • Overhead chats
  • Chat interface chats
  • The models of who they are interacting with

two-zee avatar Mar 19 '24 05:03 two-zee

New plugin no-steven: https://github.com/two-zee/runelite-plugins/tree/9348b583d580d402c784509af64d13bb6be9d4e3

Personally, I'm not keep on entity hiding players like this. Other maintainers can chime in but this is moderately unfair if someone happens to be named steven.

raiyni avatar Mar 19 '24 20:03 raiyni

I do have a config toggle that enables only checking for case-sensitive "SteVen", and I can gladly enable that by default.

Additionally, their names tend to follow a certain pattern ("SteVen" + 6 characters). Would it make a difference to you if I changed my strict mode to look for a regex that more closely matches their names?

Of course, I also don't want any innocent Stevens to be hit by this plugin, so let me know if there's anything I can do to make this more compliant.

two-zee avatar Mar 19 '24 20:03 two-zee

I just changed strict mode to be on by default, and made it match against name length as well.

two-zee avatar Mar 20 '24 02:03 two-zee

I apologize in advance as I'm not sure what the typical SLO is on getting these approved, but does your comment mean that this should be closed?

two-zee avatar Mar 20 '24 23:03 two-zee

No, we would close the PR if we came to that decision. I expect your changes are probably sufficient, but I haven't reviewed this plugin and ron probably has not re-reviewed this since those have been implemented.

Nightfirecat avatar Mar 20 '24 23:03 Nightfirecat

Thank you for the quick response, I wasn't meaning to rush anybody, just not used to how you all handle these requests.

I made what should be the final commit after forgetting to re-add my LICENSE.

two-zee avatar Mar 20 '24 23:03 two-zee