holidays icon indicating copy to clipboard operation
holidays copied to clipboard

Add Maldives Holidays

Open ahmedmansoor opened this issue 1 year ago • 4 comments

  • [x] New Year's Day
  • [x] First day of Ramadan
  • [x] Last 10 Days of Ramadan - Day 1
  • [x] Last 10 Days of Ramadan - Day 2
  • [x] Last 10 Days of Ramadan - Day 3
  • [x] Last 10 Days of Ramadan - Day 4
  • [x] Last 10 Days of Ramadan - Day 5
  • [x] Last 10 Days of Ramadan - Day 6
  • [x] Last 10 Days of Ramadan - Day 7
  • [x] Last 10 Days of Ramadan - Day 8
  • [x] Last 10 Days of Ramadan - Day 9
  • [x] Last 10 Days of Ramadan - Day 10
  • [x] Eid al-Fitr
  • [x] On the occasion of Eid al-Fitr - 2nd day
  • [x] On the occasion of Eid al-Fitr - 3rd day
  • [x] Labour Day
  • [x] Hajj Day
  • [x] Eid al-Adha
  • [x] On the occasion of Eid al-Adha - 2nd day
  • [x] On the occasion of Eid al-Adha - 3rd day
  • [x] Islamic New Year
  • [x] Independence Day
  • [x] On the occasion of the Independence Day
  • [x] National Day
  • [x] Prophet Muhammad (SAW)'s Birthday
  • [x] The Day Maldives Embraced Islam
  • [x] Victory Day
  • [x] Republic Day

reference: Public Holidays in the Maldives Academic Calendar | Min of Education

ahmedmansoor avatar Jan 18 '24 06:01 ahmedmansoor

Hi @ahmedmansoor

  • It does not work for the year 2000. Because there are two Ramadan holidays
  • Package "geniusts/hijri-dates" gives wrong result for 1 Sewwal in 2025 and some years.

thecaliskan avatar Jan 18 '24 19:01 thecaliskan

Hi @ahmedmansoor

  • It does not work for the year 2000. Because there are two Ramadan holidays
  • Package "geniusts/hijri-dates" gives wrong result for 1 Sewwal in 2025 and some years.

@thecaliskan I've tested for 2000 in the latest version, you may check. Also, if we need adjustments for the second half of 2025's hijri calendar, it will be announced after 6 months this year or at the end of this year. Current results for 2025 align with the dates published at this time.

ahmedmansoor avatar Jan 20 '24 03:01 ahmedmansoor

A few other PRs (https://github.com/spatie/holidays/pull/56) are working on Islamic holidays too. It might be useful to work together on this one. I would prefer a single implementation for those calculations which all countries with Islamic holidays could reuse.

Nielsvanpach avatar Jan 20 '24 11:01 Nielsvanpach

A few other PRs (#56) are working on Islamic holidays too. It might be useful to work together on this one. I would prefer a single implementation for those calculations which all countries with Islamic holidays could reuse.

@Nielsvanpach OK I'll check on that. It's doable, hopefully, though Islamic holiday dates may vary by a day or two among countries due to regional differences in moon sightings.

ahmedmansoor avatar Jan 20 '24 13:01 ahmedmansoor

Hi @Nielsvanpach. I've created a new PR #186, as I messed up this one during git rebasing. Sorry about that. I've also created a Hijri Calendar trait so others can use geniusts/hijri-dates to calculate Hijri dates.

ahmedmansoor avatar Jan 27 '24 17:01 ahmedmansoor