Nicholas Yang

Results 22 comments of Nicholas Yang

Okay, so turns out that you can't just give the editorState to stateToHTML. You need to give the contentState to the function. You can grab it from `editorState._immutable.currentContent`, but that...

Happy to work on this (exploring using walrus as a compiler backend as well). There's already a `FunctionKind::Uninitialized`, so we can use that. It could be as simple as adding...

After looking at the code some more, the error handling is actually the tricky bit. Right now `fn emit` doesn't return a Result, so we can't error cleanly on trying...

Bump @alexcrichton

I like this idea! Some feedback: - I don't think we need a toggle for input. - To reduce visual clutter, we could group the Rome outputs and Prettier outputs...

I like this! I was also thinking of having something that'd make it easy to open an issue or even have a panic handler that says "hey, Rome crashed, here's...

This is an interesting idea! It's essentially a decompilation tool. One idea I had was to allow people to write format IR directly using s-expressions or a simple DSL. It...

I have some concerns about a numerical metric. Testing out Rome on some small projects, I've noticed that there are large diffs that occur from very small changes like trailing...

Ah, clap changed its help output in v4, so bumping it broke some tests. Also adding shim to the cargo workspace broke a couple things. Fixing it....

Unless I'm misunderstanding, this prevents even spinning up an action, which is a lot nicer versus always spinning up an action and early exiting.