Nicholas Boll

Results 74 comments of Nicholas Boll

We are in the process of upgrading to Storybook 5.2 and are planning to inline prop documentation. This will essentially deprecate prop definitions in the `Readme.md` files so they are...

I ran into issues with the different margins around the different screen sizes. The modals are centered, but having a different top and bottom margin throw off the center calculations....

Modals now grow to fit contents with a maximum size. So functionally, this is solved. What's left for a question is margins via design.

Related: #790, #786

Media Modal: https://codesandbox.io/s/v7-media-modal-x3wc28?file=/src/App.tsx ActionBar Modal: https://codesandbox.io/s/v7-actionbar-modal-4gf6nt?file=/src/App.tsx

We've dropped support for IE11 and won't be fixing this. There is a workaround internal teams use and we'll leave the existing code so the current workaround continues to work.

I noticed there's no focus styling for buttons in a segmented control states table. To contrast, the `SegmentedControl` in `main` has `focus` states: A state table might help or at...

An example with multiple errors https://codesandbox.io/s/formfield-multiple-errors-9yzxyg