canvas-kit
canvas-kit copied to clipboard
More Modal variants
🚀 Documentation Proposal
Design has identified 2 additional variants that solve common use-cases we've seen:
Basic Modal
I'd say this is what we have now. No change needed here.
Modal + Action Bar
I don't think we need a subcomponent for this. The example can use a special ActionBar component defined in the example. Here's an example: https://codesandbox.io/s/v7-actionbar-modal-4gf6nt
Media modals
These are modals that have an image or video as the primary content. The example can use a special MediaContainer component in the example. Here's an example: https://codesandbox.io/s/v7-media-modal-x3wc28
Motivation
Having these examples in our documentation will make it easier for teams to copy/paste/modify to suite their needs. I'm not sure we need special subcomponents to support these cases. The ask is extra examples added to the documentation of the Modal page.
Related: #790, #786
Media Modal: https://codesandbox.io/s/v7-media-modal-x3wc28?file=/src/App.tsx ActionBar Modal: https://codesandbox.io/s/v7-actionbar-modal-4gf6nt?file=/src/App.tsx
I'd like to help out with this issue. Would it be okay if I brought in the examples @NicholasBoll posted?
Example with action is still planned