canvas-kit icon indicating copy to clipboard operation
canvas-kit copied to clipboard

More Modal variants

Open NicholasBoll opened this issue 5 years ago • 2 comments

🚀 Documentation Proposal

Design has identified 2 additional variants that solve common use-cases we've seen:

Basic Modal

I'd say this is what we have now. No change needed here.

Screen Shot 2020-05-26 at 3 42 04 PM

Modal + Action Bar

I don't think we need a subcomponent for this. The example can use a special ActionBar component defined in the example. Here's an example: https://codesandbox.io/s/v7-actionbar-modal-4gf6nt

Screen Shot 2020-05-26 at 3 41 54 PM

Media modals

These are modals that have an image or video as the primary content. The example can use a special MediaContainer component in the example. Here's an example: https://codesandbox.io/s/v7-media-modal-x3wc28

Screen Shot 2020-05-26 at 3 42 16 PM

Motivation

Having these examples in our documentation will make it easier for teams to copy/paste/modify to suite their needs. I'm not sure we need special subcomponents to support these cases. The ask is extra examples added to the documentation of the Modal page.

NicholasBoll avatar May 26 '20 21:05 NicholasBoll

Related: #790, #786

NicholasBoll avatar Aug 17 '20 21:08 NicholasBoll

Media Modal: https://codesandbox.io/s/v7-media-modal-x3wc28?file=/src/App.tsx ActionBar Modal: https://codesandbox.io/s/v7-actionbar-modal-4gf6nt?file=/src/App.tsx

NicholasBoll avatar Sep 20 '22 20:09 NicholasBoll

I'd like to help out with this issue. Would it be okay if I brought in the examples @NicholasBoll posted?

danbrady avatar Apr 07 '23 13:04 danbrady

Example with action is still planned

RayRedGoose avatar May 25 '23 15:05 RayRedGoose