Nicolas Bayle comments

Results 16 comments of


                                            Nicolas Bayle

TimelockController: Use default admin role

Hi! Does this issue need a pr?

Faulty function documentation in `INonfungiblePositionManager`

PR #311

Don't use wallet object for `account.createInstruction` function

Hi! Can I start working on this issue and propose a PR? Thanks!

Don't use wallet object for `account.createInstruction` function

PR #2116

makefile: add test scripts for local testing

Hi! I was wondering what tests to include in "local testing". Thanks!

Don't use wallet object for account.createInstruction function 2112

A pleasure :) Does the code need to throw an exception if `this._provider.publicKey` is undefined? Something similar to this: ```javascript // @ts-expect-error if (this._provider.publicKey === undefined) { throw new Error(...

Don't use wallet object for account.createInstruction function 2112

Understood. Any ideas on what might cause the tests to fail?

Don't use wallet object for account.createInstruction function 2112

Okay thanks for your help! Will check it out tomorrow

Don't use wallet object for account.createInstruction function 2112

I modified my PR and ran the tests locally, they all passed! Let me know what to do next

Don't use wallet object for account.createInstruction function 2112

Does the non passing test have anything to do with this PR?