Dominik Charousset
Dominik Charousset
- [x] The `always_quote_strings` in the `stringification_inspector` seems unused (see https://github.com/actor-framework/actor-framework/pull/1960#issuecomment-2466413629) and probably can be removed as well.
Do you really need the full-fledged CAF-to-CAF communication to run over WebSocket? What use case do you have? If all you need is shipping (binary) CAF messages over WebSocket: you...
Well, there are tools to tunnel TCP over WebSocket. Maybe that's the easiest way in your case?
We could also consider leaving the pimpl-design as-is with a few tweaks: - get rid of the inheritance hierarchy for the user-facing types like `json_reader` - offer an `as_serializer` /...
> I have a [`in_flight` disposable ](https://github.com/actor-framework/actor-framework/pull/2132/changes#diff-9d15f7b81e3fb057df9a73a1517ed1589ca6ca4ef42b6c3f8e6df2ea90278c12R80)in the `state_`. It's a [composite disposable created with](https://github.com/actor-framework/actor-framework/pull/2132/changes#diff-3ad181645d1bfa7aeff44e516eef7a0697f8bb19bc31fdc2cdb85c1f8a907c53R143) all the disposables returned from `self->request_response_timeout` in one case, and `clock.schedule_message` in the other case....
While we're at it: we should add the necessary code paths for switching to `std::expected` and then safeguard them behind a CMake option. This allows us to test the STL...
I'll hold on to merging this until I have tested this a bit more to see that it actually works as intended. On my development box, TLS < 1.2 seems...
Thanks for reporting! I'm currently prioritizing https://github.com/zeek/broker/issues/426, but I'll pick this one up afterwards.
> Did you have a chance to look at this, [@Neverlord](https://github.com/Neverlord)? My assumption was that the Broker WebSocket API is basically obsolete now with Arne's work on shifting the WebSocket...
@ckreibich thank you for the feedback! I've split the PR into four logical commits: two prepare steps, the actual change, and one cleanup commit that only removes obsolete files. The...