Dominik Charousset

Results 200 comments of Dominik Charousset

Weird, we set `HeaderFilterRegex: 'broker/.*.hh'` in the clang-tidy file to ignore everything from other sources. Let me look into it.

I can see that diagnostic locally with 16.0.5 as well. I have no idea why it thinks that could be a garbage value. That line just unpacks an `expected` value....

Out of curiosity, how did you end up with mismatched versions? Building Zeek from source should always give you the proper versions and the binary distributions should be consistent as...

To clarify, the actual report was about memory bloat. So far, I couldn't reproduce the bloat itself. What I did find is that Broker seems to do fine for throughput,...

Reverting back to draft, it doesn't deserialize the topic from the data yet.

> I also like the idea of implementing proper request-driven scraping in 6.1 instead of constant push from all nodes to the manager. I'm not convinced that this is a...

> Agreed — I'm relieved because we have so many options here. The `find_if()` looks expensive because it's implementing an identity comparison for a set of labels (yes?) so we...