Dominik Charousset

Results 200 comments of Dominik Charousset

@timwoj, @ckreibich: aside from getting CI green: I sat down with `prometheus-cpp` to figure out how to best integrate the build. The way it has been integrated in Zeek has...

All right, I've sat down with CMake some more to get the `ZeekBundle` work on Windows (cannot mix debug and release libraries) and with multi-configuration generators. I've tested it on...

@ckreibich the CI failures have nothing to do with the changes. PR-wise, this is done now. The Zeek-side PR is also green now.

@bbannier thanks! Rebased and updated the Zeek-side PR as well.

I see a couple issues with this script: The `prometheus-cpp` library installs CMake package files, so it is very confusing why there should be a find script for it at...

This is a limitation when using the I/O module. When sending an actor handle to another node in the network, CAF exposes the address to that actor to others. CAF...

> Is it possible to globally opt-out of sending caf::exit_reason::unreachable when the reference count drops to zero, so that the shutdown behavior is at least consistent throughout the application? Not...

The design of the I/O module dates back to over a decade and it didn't age well. We are well aware of that. Aside from the transparency issues you've described,...

Certainly makes sense to have this configurable. An option to configure the size of the length field might be a good idea as well while we're at it. Currently, we...

> Are there any plans to make this configurable? Yes. However, making the size configurable will break the ABI because we need to change `config_type` (and thus the type of...