Tobias Bachert
Tobias Bachert
The batching functionality doesn't depend on force-flushing; the batch processor should still call `::export()` with the batch in `::onEnd()`, just without calling `::forceFlush()` afterwards. [SpanExporter::forceFlush()](https://github.com/open-telemetry/opentelemetry-specification/blob/5fb819c72e34cb21fe1ce5acba1dc93c2216ecb1/specification/trace/sdk.md#forceflush-2) > ForceFlush SHOULD only be...
ok with me too. I have no issues with keeping `::activate()` (I mentioned/like `::makeCurrent()` because its name is a direct reference to `::current()`).
Single and multi-header propagation should be implemented as a single propagator with two [configurations](https://github.com/open-telemetry/opentelemetry-specification/blob/dc9467abf21437327ec563244484177140c1a97d/specification/context/api-propagators.md#configuration). The debug flag has to be propagated ([B3 Extract](https://github.com/open-telemetry/opentelemetry-specification/blob/dc9467abf21437327ec563244484177140c1a97d/specification/context/api-propagators.md#b3-extract)), the specification PR mentioned storing it in...
We should allow users to choose between the two modes, either by having a singleton for each mode, or by exposing the constructor with an argument that allows choosing between...
No, we still need the combined `::extract()` behavior - I meant replacing `B3Propagator::getInstance()` with a method for each configuration mode, something like `::getB3SingleHeaderInstance()` and `::getB3MultiHeaderInstance()`.
Should be ready after a rebase.
I added a configuration example that uses env substitution. We cannot fully replicate the environment variable configuration: - variables with list/map value cannot be used, injecting YAML structures is disallowed...
We should wait until #1256 is merged, I think most workflows will fail otherwise. > could the important parts of otel-sdk-configuration come into the opentelemetry org? Yes (but it should...
> Could you add an example of how a component could be configured using environment variables? https://github.com/open-telemetry/opentelemetry-configuration/pull/76 provides a starter template that contains all env vars that map cleanly to...
Scopes must be detached in the execution context (Fiber/Coroutine) they were created in. ```php $span = $tracer->spanBuilder('init')->startSpan(); $scope = $span->activate(); Loop::addTimer(5, async(function () use ($span) { $span->end(); })); $scope->detach(); ```...