Tobias Bachert
Tobias Bachert
> I was under the impression this would work since otel keeps track of fibers and the async call creates a new fiber? It would work if `async()` would create...
IMO we shouldn't move everything out of the SDK, I would keep `Variables` (and `Defaults` + `KnownValues` if needed) in the component that uses them. `Configuration::validateVariableType()` + `ValueTypes` + `VariableTypes`...
> I'm hesitant to do this, because then contrib packages need to depend on SDK to fetch config (unless we start splitting config up into SDK, general, and possibly also...
> OpenTelemetry should play nice with other packges making use of fibers, no? Fiber support is not enabled out-of-the-box, see also https://github.com/opentelemetry-php/context?tab=readme-ov-file#async-applications. `phpro/grumphp` uses `amphp/amp: ^3` -> you could install...
Metrics SDK changes: - [ ] [`MetricProducer`](https://opentelemetry.io/docs/specs/otel/metrics/sdk/#metricproducer) (v1.16.0, stable since v1.25.0), can replace `MetricSourceRegistryInterface` and logic in `ExportingReader::add()` > The SDK’s in-memory state MAY implement the MetricProducer interface for convenience....
> I think our default implementation might be based on LowMemory temporality Yes, we use `LowMemory` by default (declarative and env based config are already using `Cumulative` by default). >...
Previous discussions: - https://github.com/open-telemetry/opentelemetry-php-contrib/pull/259#discussion_r1586858959 - https://github.com/open-telemetry/opentelemetry-php/pull/1149#issuecomment-1842639422 Tl;dr: fixed schema urls should be used instead of `TraceAttributes::SCHEMA_URL`.
> Is this because the OpenTelemetry PHP extension is looking for the environment variables before the DotEnv component can populate them? Yes, the SDK is initialized (using composer `autoload/files`) before...
An alternative idea if we want to avoid duplicating the "load implementations from `composer.json`" approach: The main difference between the solution in this PR and an SPI-based approach is the...