Daniel McKnight

Results 59 comments of Daniel McKnight

+1 on this. As far as system dependencies, I believe the docs would only need to include: ``` sudo apt update sudo apt install -y gcc libfann-dev swig libssl-dev portaudio19-dev...

> unrelated to #1221 , thats just google STT blocking words because of the implementation on selene side. with the chromium plugin it can be disabled so that code could...

I do see advantages to passing something simple like 'phrase'. My initial thought was actually just to add `message` so it would be an optional parameter in addition to `phrase`....

Is there a strong preference from anyone here one way or the other? I like Ake's suggestion as it means less work to maintain backwards comatibility now, though I see...

> This could be a pre-STT, post-TTS, or used for any other purpose I hadn't thought of the post-TTS use case, but that would be very useful for cleaning up...

> Wouldn't this be improved a bit when the big XDG PR gets included, moving most if not all configs and the self.file_system under the BaseDirectory.save_config_path(...) ? This was my...

> One one hand it makes sense to separate them since one is a configuration where as the `self.file_system` is for general data. > On another hand is having two...

>If a skill creator wipes the file_system location with an rm * the settings.json should not be affected This is a good point that settings should generally be protected from...

> Some api methods for that would be an excellent addition, especially restore default would be great. Not sure what you mean with modify existing config since that is there...

I think that all makes sense.. FWIW, I would just define a `SkillSettings` object with dict-like set/get support and added methods for `reset_defaults`, and maybe `sync_backend` for manual pull of...