Daniel McKnight

> Thanks for flagging this. I think the registering should raise the exception but it should be caught and logged by the enable_intent. Does that sound like a good solution?...

+1 on this. I like this [implementation in ovos-core](https://github.com/OpenVoiceOS/ovos-core/commit/6160306cea4510e32c0df5856d6b325573f0f0d8#diff-de9c5f1686f10b9d808e72acfed8cd86836694b4fee92bb17f2e5afed006beabR238) because it lets the user decide; by default I think it makes sense to wait, but there are cases where you...

I like the backwards-compatible implementation, this does make the return type of `get_response` unknown (currently `Optional[str]`). Should validator return be enforced as a `str`, or left up to the skill...

> Hmmm - good point. > > Personally my first reaction is not to type cast it to a string and leave it up to the person defining the validator....

It appears that msk submitted the "master" branch or my repository, though I had the "dev" branch checked out in the local directory I called msk submit from. Is this...

Okay, default branch makes some sense, though it could be a nice addition for that to be specified in the CLI when submitting a change. I agree msk does make...

Okay, I noticed the failures didn't appear to involve my skill and all recently submitted skills seem to be affected. Let me know if there is anything I need to...

I would recommend setting up a Service and using ServiceConnection objects in any activity you want to use your socket in. https://developer.android.com/guide/components/bound-services

> This won't break anything, but I'm curious what purpose it serves to have a big list of language codes? The `get_full_lang_code` is generically useful for getting a default BCP-47...

EDIT: Looked at this again today with the full manual and it seems to be working as it should (maybe because I sent AT+Z to reset). It looks like many...